Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 )
Change subject: IMPALA-1760: Implement shutdown command ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/10744/8/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/10744/8/common/thrift/ImpalaInternalService.thrift@931 PS8, Line 931: // Called to initiate shutdown of this backend. : TRemoteShutdownResult RemoteShutdown(1:TRemoteShutdownParams params); > Is it possible for me to port this to KRPC now? I guess when I wrote this p Yes, I think if you cherry-pick that patch mentioned above, you should be able to add a new RPC in control_service.proto and define the handler similar to what we did in ReportExecStatus() RPC. Again, didn't mean to hold you back so if this patch goes in first, we can do the porting as a separate patch. Looking at this patch, this should hopefully be straightforward albeit may be some question about timeout which I may need to take a closer look. -- To view, visit http://gerrit.cloudera.org:8080/10744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5606ccfec84db4482c1e7f0f198103aad141a0 Gerrit-Change-Number: 10744 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 03 Jul 2018 17:23:55 +0000 Gerrit-HasComments: Yes
