Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24297 )

Change subject: IMPALA-14600: Support HBO for AggregationNode cardinality
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24297/12/fe/src/main/java/org/apache/impala/analysis/SlotRef.java
File fe/src/main/java/org/apache/impala/analysis/SlotRef.java:

http://gerrit.cloudera.org:8080/#/c/24297/12/fe/src/main/java/org/apache/impala/analysis/SlotRef.java@324
PS12, Line 324:       if (desc_ != null && !desc_.isScanSlot() && 
desc_.getSourceExprs().size() == 1) {
rawPath_ is the column alias for inline view output exprs. We can't use the 
alias from the query. Patch set 13 fixes this to check SlotDescriptor first. If 
it's a non-scan slot and has a source expr, it's an alias and we use the column 
name in the base table.



--
To view, visit http://gerrit.cloudera.org:8080/24297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0fafaf9d827f3bf533b1af7e62fdb2303c126ce
Gerrit-Change-Number: 24297
Gerrit-PatchSet: 14
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Sun, 19 Jul 2026 08:13:46 +0000
Gerrit-HasComments: Yes

Reply via email to