Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/24297 )
Change subject: IMPALA-14600: Support HBO for AggregationNode cardinality ...................................................................... Patch Set 14: Code-Review+1 (2 comments) This was already well reviewed by Steve Carlin, so I am leaving just a couple of minor comments; nothing actionable. http://gerrit.cloudera.org:8080/#/c/24297/8/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/24297/8/common/thrift/Frontend.thrift@789 PS8, Line 789: // HDFS URI for the jar > > Another possibility is to have the TRuntimeFilterDesc structure contain a I am late to this discussion. Definitely like the idea of moving the parent id to the TPlanNode (which is already done in the later patch). On the later discussion points about the verbose explain plan, I think it is best to keep it simple and show only the RFs for the target node (Scan) even in the verbose plan. The intermediate plan nodes don't do anything with the RF themselves. They are indirect beneficiaries of what the child produced. http://gerrit.cloudera.org:8080/#/c/24297/10/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/24297/10/fe/src/main/java/org/apache/impala/planner/PlanNode.java@119 PS10, Line 119: protected PlanNode parent_; In the future when CTEs are supported, a single producer may have 2 or more consumers (parents). In those cases, we will need a list but for now this should be good. -- To view, visit http://gerrit.cloudera.org:8080/24297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0fafaf9d827f3bf533b1af7e62fdb2303c126ce Gerrit-Change-Number: 24297 Gerrit-PatchSet: 14 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 22 Jul 2026 23:17:10 +0000 Gerrit-HasComments: Yes
