Hello Zoltan Borok-Nagy, Csaba Ringhofer, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24504
to look at the new patch set (#6).
Change subject: IMPALA-15101: Add Iceberg UUID primitive type
......................................................................
IMPALA-15101: Add Iceberg UUID primitive type
Introduce UUID as a new Impala primitive type with 16-byte inline tuple
slot storage. This patch adds only the foundational type-system, parser,
DDL analysis, and Iceberg schema mapping support needed to recognize
UUID columns. Query execution features (read path, predicates, casts,
aggregates) will follow in separate patches.
- Add TYPE_UUID to FE/BE/thrift
- Add UUID SQL keyword and DDL rules restricting UUID columns to Iceberg
tables
- Reject nested UUID types (ARRAY/MAP/STRUCT) in non-Iceberg CREATE/ALTER
TABLE
- Map Iceberg UUID schema fields to Impala Type.UUID for catalog/DESCRIBE
- Add minimal UuidCompatibility matrix entries required for catalog startup
- Defer UUID builtin registration until later patches add BE runtime support
- Add minimal BE inline-slot plumbing and uuid-util helpers/tests
Testing:
- FE tests:
- ParserTest for UUID type definitions in DDL and complex types
- AnalyzeDDLTest for Iceberg CREATE/ALTER TABLE with UUID columns
- Negative tests in AnalyzeExprsTest for UUID expressions
- BE tests:
- BE tests for UUID util functions
Change-Id: Iefc73aefe73b6144c929ec37b0cb333007cf8bfe
Assisted-by: Composer 2.5
---
M be/src/codegen/llvm-codegen.cc
M be/src/exprs/anyval-util.cc
M be/src/exprs/anyval-util.h
M be/src/exprs/null-literal.cc
M be/src/exprs/scalar-expr.inline.h
M be/src/exprs/scalar-fn-call.cc
M be/src/exprs/slot-ref.cc
M be/src/runtime/descriptors.cc
M be/src/runtime/types.cc
M be/src/runtime/types.h
M be/src/udf/udf.h
M be/src/util/CMakeLists.txt
M be/src/util/symbols-util.cc
A be/src/util/uuid-util-test.cc
A be/src/util/uuid-util.h
M common/thrift/Types.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/AlterTableAddColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/AlterTableReplaceColsStmt.java
M fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java
M fe/src/main/java/org/apache/impala/analysis/CaseExpr.java
M fe/src/main/java/org/apache/impala/analysis/CastExpr.java
M fe/src/main/java/org/apache/impala/analysis/ColumnDef.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/InPredicate.java
M fe/src/main/java/org/apache/impala/analysis/IsNullPredicate.java
M fe/src/main/java/org/apache/impala/analysis/SlotRef.java
M fe/src/main/java/org/apache/impala/catalog/BuiltinsDb.java
M fe/src/main/java/org/apache/impala/catalog/Column.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/Function.java
M fe/src/main/java/org/apache/impala/catalog/PrimitiveType.java
M fe/src/main/java/org/apache/impala/catalog/ScalarFunction.java
M fe/src/main/java/org/apache/impala/catalog/ScalarType.java
M fe/src/main/java/org/apache/impala/catalog/Type.java
A fe/src/main/java/org/apache/impala/catalog/UuidCompatibility.java
M fe/src/main/java/org/apache/impala/util/IcebergSchemaConverter.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M java/calcite-planner/src/test/java/org/apache/impala/CompatibilityTest.java
M tests/hs2/test_hs2.py
44 files changed, 504 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/24504/6
--
To view, visit http://gerrit.cloudera.org:8080/24504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iefc73aefe73b6144c929ec37b0cb333007cf8bfe
Gerrit-Change-Number: 24504
Gerrit-PatchSet: 6
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
