Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24504 )
Change subject: IMPALA-15101: Add Iceberg UUID primitive type ...................................................................... Patch Set 7: (1 comment) > Nice patch! I can upgrade my vote to +2 if you fix your comment > (about formatting) Sure, Done. http://gerrit.cloudera.org:8080/#/c/24504/6/be/src/runtime/types.h File be/src/runtime/types.h: http://gerrit.cloudera.org:8080/#/c/24504/6/be/src/runtime/types.h@200 PS6, Line 200: if (type == TYPE_CHAR || type == TYPE_FIXED_UDA_INTERMEDIATE) return len == o.len; : if (type == TYPE_DECIMAL) return precision == o.precision && scale == o.scale; : i > Note to self: make the formatting consistent with other lines. Done -- To view, visit http://gerrit.cloudera.org:8080/24504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iefc73aefe73b6144c929ec37b0cb333007cf8bfe Gerrit-Change-Number: 24504 Gerrit-PatchSet: 7 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 24 Jul 2026 09:34:05 +0000 Gerrit-HasComments: Yes
