Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24521 )
Change subject: IMPALA-15052: Add read support for unshredded VARIANT values ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/24521/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24521/9//COMMIT_MSG@15 PS9, Line 15: Type system > It would be great to add an .md file, e.g. variant-type.md and collect some I think this should be written in user docs, filed IMPALA-15223. We currently don't have .md files so users wouldn't know they should look for it. And issues should be tracked in Jira. http://gerrit.cloudera.org:8080/#/c/24521/9//COMMIT_MSG@36 PS9, Line 36: Result display: > 1. what does DESCRIBE print? VARIANT. We already have tests for it. > 2. what does SHOW CREATE TABLE print? VARIANT. Added new test for it. > 3. what do Iceberg metadata queries return (for GEOMETRY this revealed an > Iceberg lib gap) Not strictly related to this CR, but added test for it. > 4. does impala shell work with variants? the test only use impyla Added new tests for it. > 5. what do TCLIService functions return about the type? is it translated to > STRING completely, or the client can differentiate? (GetColumns, > GetResultSetMetadata) For now we return STRING. Added a test fort his. > 6. same for beeswax (note sure how type metadata is returned there) - though > probably it would be better to simply reject fetching variants through beeswax Beeswax is a good question as we are retiring it in Impala 5. Returning STRING for now and added test. We can remove it when we remove beeswax completely. Until then it's cheap to make it work. Progress/issues should be tracked in Jira, I would not create .md files for it. Client issues are fixed and tested by this patch. http://gerrit.cloudera.org:8080/#/c/24521/9//COMMIT_MSG@37 PS9, Line 37: - VARIANT columns are serialized to their JSON representation in query : output (hs2-util, query-result-set), via the backend VariantSlotToJson : helper. > It could be mentioned that BINARY fields are base64 encoded (which is a com Done http://gerrit.cloudera.org:8080/#/c/24521/9//COMMIT_MSG@40 PS9, Line 40: : - A VARIANT value that fails to decode > this was changed Done http://gerrit.cloudera.org:8080/#/c/24521/9/fe/src/main/jflex/sql-scanner.flex File fe/src/main/jflex/sql-scanner.flex: http://gerrit.cloudera.org:8080/#/c/24521/9/fe/src/main/jflex/sql-scanner.flex@308 PS9, Line 308: keywordMap.put("variant", SqlParserSymbols.KW_VARIANT) > Strictly speaking this is a breaking change, as VARIANT was not among the r Added VARIANT to non-reserverd keywords for now. -- To view, visit http://gerrit.cloudera.org:8080/24521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f8a7c9b1d4e5f6a0c3b8d7e9f1a2b4c6d8e0f1 Gerrit-Change-Number: 24521 Gerrit-PatchSet: 10 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 27 Jul 2026 15:22:06 +0000 Gerrit-HasComments: Yes
