Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24521 )
Change subject: IMPALA-15052: Add read support for unshredded VARIANT values ...................................................................... Patch Set 12: (5 comments) Thanks for keeping up with the reviews! My only remaining concern is compatibility with Hive - we could avoid some future headache by working the same way. Beside the client interface I won't have any comments for other parts of the code. http://gerrit.cloudera.org:8080/#/c/24521/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24521/9//COMMIT_MSG@15 PS9, Line 15: Type system > I think this should be written in user docs, filed IMPALA-15223. We current ack http://gerrit.cloudera.org:8080/#/c/24521/9//COMMIT_MSG@36 PS9, Line 36: Result display: > > 1. what does DESCRIBE print? ack, missed the DESCRIBE test somehow http://gerrit.cloudera.org:8080/#/c/24521/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24521/12//COMMIT_MSG@44 PS12, Line 44: is reported as STRING/VARCHAR, there is a recent PR in Hive about this: https://github.com/apache/hive/pull/6644 It adds a VARIANT type to HS2 Thrift interface. It would be nice to get a common behavior in Hive and Impala. One thing I am not sure about is the effect of the new type on old clients. http://gerrit.cloudera.org:8080/#/c/24521/12/fe/src/main/java/org/apache/impala/catalog/Type.java File fe/src/main/java/org/apache/impala/catalog/Type.java: http://gerrit.cloudera.org:8080/#/c/24521/12/fe/src/main/java/org/apache/impala/catalog/Type.java@779 PS12, Line 779: if (isVariantType()) return java.sql.Types.VARCHAR; The JDBC connector could be also tested, see https://github.com/apache/impala/blob/08c8cf9b7f39c0fb057b11dfcb5f8d07fcb0ea12/fe/src/test/java/org/apache/impala/service/JdbcTest.java#L134 http://gerrit.cloudera.org:8080/#/c/24521/9/fe/src/main/jflex/sql-scanner.flex File fe/src/main/jflex/sql-scanner.flex: http://gerrit.cloudera.org:8080/#/c/24521/9/fe/src/main/jflex/sql-scanner.flex@308 PS9, Line 308: keywordMap.put("varchar", SqlParserSymbols.KW_VARCHAR) > Added VARIANT to non-reserverd keywords for now. nice! I didn't realize that this is an option -- To view, visit http://gerrit.cloudera.org:8080/24521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2f8a7c9b1d4e5f6a0c3b8d7e9f1a2b4c6d8e0f1 Gerrit-Change-Number: 24521 Gerrit-PatchSet: 12 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 27 Jul 2026 19:42:52 +0000 Gerrit-HasComments: Yes
