Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24372 )
Change subject: IMPALA-15043: Add Kubernetes-in-Docker E2E scripts ...................................................................... Patch Set 45: (2 comments) http://gerrit.cloudera.org:8080/#/c/24372/45/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/24372/45/tests/common/impala_test_suite.py@495 PS45, Line 495: except Exception as e: This now ignores Beeswax client setup failures unconditionally. That makes sense for remote/K8s paths where Beeswax may be intentionally absent, but in regular runs it can hide regressions. Can this be conditioned on `testing_remote_cluster` (or another explicit mode) instead of always continuing? http://gerrit.cloudera.org:8080/#/c/24372/45/tests/common/impala_test_suite.py@524 PS45, Line 524: if cls.client is None: This fallback changes test semantics by silently switching protocols when the requested default protocol is unavailable. For example, a run configured with `--default_test_protocol=hs2` can pass via HS2-HTTP/Beeswax instead of failing, which hides real HS2 regressions. Can we fail when the requested default protocol client is unavailable (or gate fallback behind an explicit opt-in for remote/K8s smoke mode)? -- To view, visit http://gerrit.cloudera.org:8080/24372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I122b99c38c8c70ab535349f92212621330f2aa55 Gerrit-Change-Number: 24372 Gerrit-PatchSet: 45 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 20:45:48 +0000 Gerrit-HasComments: Yes
