Anubhav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24372 )
Change subject: IMPALA-15043: Add Kubernetes-in-Docker E2E scripts ...................................................................... Patch Set 48: (9 comments) Done http://gerrit.cloudera.org:8080/#/c/24372/47/bin/jenkins/all-tests.sh File bin/jenkins/all-tests.sh: http://gerrit.cloudera.org:8080/#/c/24372/47/bin/jenkins/all-tests.sh@110 PS47, Line 110: exit $RET_CODE : : : : > This code would make more sense in bin/run-all-tests.sh unless there is a r Moved K8s E2E gate from Jenkins all-tests into bin/run-all-tests.sh as opt-in (K8S_E2E_TEST=false) http://gerrit.cloudera.org:8080/#/c/24372/47/bin/jenkins/run-k8s-e2e-tests.sh File bin/jenkins/run-k8s-e2e-tests.sh: http://gerrit.cloudera.org:8080/#/c/24372/47/bin/jenkins/run-k8s-e2e-tests.sh@1 PS47, Line 1: #!/usr/bin/env bash > Use this instead: #!/usr/bin/env bash Updated shebang, http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh File bin/run-k8s-e2e-tests.sh: http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh@23 PS47, Line 23: : "${IMPALA_HOME:=$(cd "${SCRIPT_DIR}/.." && pwd)}" > Don't override IMPALA_HOME if it is already set. Changed to preserve existing IMPALA_HOME and only default if unset. http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh@24 PS47, Line 24: export IMPALA_HOME > Should this script also run cd "${IMPALA_HOME}" Added cd "${IMPALA_HOME}". http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh@67 PS47, Line 67: > Use "${IMPALA_HOME}/bin/impala-python3" command instead. Switched HS2 readiness helper to impala-python3. http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh@131 PS47, Line 131: if [[ "${ready}" == "true" ]]; then : return 0 : fi > Nit: instead of duplicating this code, can the cleanup() function be called Reused cleanup() in failed port-forward path. http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh@187 PS47, Line 187: TEST_CMD=( > It's also frequently useful to be able to provide the '-k', '-x', and '--pd Confirmed and retained passthrough support ("$@") to run-tests.py, validated via dry-run with extra pytest args. http://gerrit.cloudera.org:8080/#/c/24372/47/helm/impala/README.md File helm/impala/README.md: http://gerrit.cloudera.org:8080/#/c/24372/47/helm/impala/README.md@407 PS47, Line 407: impala-impala-impalad > Is this a typo? Not a typo. The chart names services as <release-name>-impala-<component>, so with release name impala, the impalad service becomes impala-impala-impalad. http://gerrit.cloudera.org:8080/#/c/24372/47/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/24372/47/tests/common/impala_test_suite.py@493 PS47, Line 493: cls.beeswax_client = cls.create_impala_client_internal(protocol=BEESWAX) > Rather than modifying this file, set ENABLE_BEESWAX=false in the test execu Reverted tests/common/impala_test_suite.py behavior changes and set ENABLE_BEESWAX=false in bin/run-k8s-e2e-tests.sh. -- To view, visit http://gerrit.cloudera.org:8080/24372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I122b99c38c8c70ab535349f92212621330f2aa55 Gerrit-Change-Number: 24372 Gerrit-PatchSet: 48 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 22:23:19 +0000 Gerrit-HasComments: Yes
