Anubhav Jindal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24368 )
Change subject: IMPALA-15028: Add Helm chart render assertions ...................................................................... Patch Set 50: (2 comments) Done http://gerrit.cloudera.org:8080/#/c/24368/48/helm/impala/tests/assert_chart.py File helm/impala/tests/assert_chart.py: http://gerrit.cloudera.org:8080/#/c/24368/48/helm/impala/tests/assert_chart.py@252 PS48, Line 252: ) > This assertion can false-pass. Counting `emptyDir: {}` globally (`>= 2`) do Agreed, global emptyDir count was too loose. I changed the test to assert Kudu-specific volume behavior directly (kudu-master-data and kudu-tserver-data both render as emptyDir) and to verify Kudu PVC-style references (claimName / volumeClaimTemplates) are absent. http://gerrit.cloudera.org:8080/#/c/24368/48/helm/impala/tests/run-chart-tests.sh File helm/impala/tests/run-chart-tests.sh: http://gerrit.cloudera.org:8080/#/c/24368/48/helm/impala/tests/run-chart-tests.sh@103 PS48, Line 103: if helm template impala-secure-no-principal "${CHART_DIR}" \ > We validate missing keytab/TLS secret failures, but we don’t validate missi Done. Added a dedicated negative test for security.kerberos.enabled=true with missing principal, and assertion coverage for the expected validation error. I also updated the existing missing-keytab case to set principal so that test continues to validate keytab-specific failure. -- To view, visit http://gerrit.cloudera.org:8080/24368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I313be431e81a4b98370e51d298b7b2d35e0aded8 Gerrit-Change-Number: 24368 Gerrit-PatchSet: 50 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Tue, 28 Jul 2026 21:37:29 +0000 Gerrit-HasComments: Yes
