Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24368 )
Change subject: IMPALA-15028: Add Helm chart render assertions ...................................................................... Patch Set 52: (6 comments) http://gerrit.cloudera.org:8080/#/c/24368/50/bin/jenkins/all-tests.sh File bin/jenkins/all-tests.sh: http://gerrit.cloudera.org:8080/#/c/24368/50/bin/jenkins/all-tests.sh@35 PS50, Line 35: # platforms that don't install ninja. > Done, chart test gate now defaults off (HELM_CHART_TEST=false) Done http://gerrit.cloudera.org:8080/#/c/24368/50/bin/jenkins/all-tests.sh@101 PS50, Line 101: exit $RET_CODE : : : : > Moved integration from bin/jenkins/all-tests.sh to bin/run-all-tests.sh Done http://gerrit.cloudera.org:8080/#/c/24368/52/bin/jenkins/all-tests.sh File bin/jenkins/all-tests.sh: http://gerrit.cloudera.org:8080/#/c/24368/52/bin/jenkins/all-tests.sh@34 PS52, Line 34: # Use ninja for better control over link concurrency. Allow overriding this for : # platforms that don't install ninja. Nit: please restore this file to the version from master so that it does not get modified by this change. http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/README.md File helm/impala/README.md: http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/README.md@388 PS50, Line 388: helm upgrade impala ./helm/impala -n impala \ > Added dependency docs in Helm README for running the chart harness. Done http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/assert_chart.py File helm/impala/tests/assert_chart.py: http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/assert_chart.py@1 PS50, Line 1: #!/usr/bin/env impala-python3 > Updated assert_chart.py shebang to #!/usr/bin/env impala-python3 and kept i Done http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/run-chart-tests.sh File helm/impala/tests/run-chart-tests.sh: http://gerrit.cloudera.org:8080/#/c/24368/50/helm/impala/tests/run-chart-tests.sh@153 PS50, Line 153: echo "Expected helm template to fail without external Ranger admin URL." > Updated run-chart-tests.sh to invoke assert_chart.py directly. Done -- To view, visit http://gerrit.cloudera.org:8080/24368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I313be431e81a4b98370e51d298b7b2d35e0aded8 Gerrit-Change-Number: 24368 Gerrit-PatchSet: 52 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Mon, 10 Aug 2026 18:05:18 +0000 Gerrit-HasComments: Yes
