Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24190 )
Change subject: IMPALA-14882: part1: Convert arrow record batch to impala tuple batch ...................................................................... Patch Set 31: (2 comments) Also fixed a bug with the paimon scanner loop not exiting when reaching a LIMIT. http://gerrit.cloudera.org:8080/#/c/24190/29/be/src/exec/arrow-converter.h File be/src/exec/arrow-converter.h: http://gerrit.cloudera.org:8080/#/c/24190/29/be/src/exec/arrow-converter.h@49 PS29, Line 49: RuntimeState* state); > How about adding a `uint8_t* value_buffer` parameter here so that we don't Done http://gerrit.cloudera.org:8080/#/c/24190/26/be/src/exec/arrow-converter.cc File be/src/exec/arrow-converter.cc: http://gerrit.cloudera.org:8080/#/c/24190/26/be/src/exec/arrow-converter.cc@268 PS26, Line 268: public SlotWriterImpl<StringSlotWriter<ArrowArrayType> > Done This didn't work. During paimon scan, a batch of arrow data is read at once and then processed. The problem is that requesting a new batch can happen while some rows in the current row batch still correspond to the previous batch. So I reintroduced the allocate and copy (except for smallable strings). -- To view, visit http://gerrit.cloudera.org:8080/24190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea544b3c71d9211c893f0fec3527ebe84155ebcd Gerrit-Change-Number: 24190 Gerrit-PatchSet: 31 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: jichen <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 12:56:21 +0000 Gerrit-HasComments: Yes
