Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24190 )
Change subject: IMPALA-14882: part1: Convert arrow record batch to impala tuple batch ...................................................................... Patch Set 33: (4 comments) Leaving a few comments, I still want to go through the bulk of arrow-converter.cc in more detail. http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/benchmarks/arrow-converter-benchmark.cc File be/src/benchmarks/arrow-converter-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/benchmarks/arrow-converter-benchmark.cc@48 PS33, Line 48: // Mixed 180 182 183 0.248X 0.248X 0.248X This primarily shows Mixed is slower. How does this compare to copying a tuple batch or an arrow record batch? I'm looking for an upper-bound on performance that might serve as a goal. http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/benchmarks/arrow-converter-benchmark.cc@116 PS33, Line 116: nit: excess whitespace http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/exec/arrow-converter.cc File be/src/exec/arrow-converter.cc: http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/exec/arrow-converter.cc@54 PS33, Line 54: RETURN_IF_ERROR(WriteSlotBatch(arr.get(), 0, num_rows, slot_desc, Have you benchmarked operating on a batch of tuple_mems and writing a column at a time? http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/exec/paimon/CMakeLists.txt File be/src/exec/paimon/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/exec/paimon/CMakeLists.txt@a25 PS33, Line 25: Should the file itself also be removed? -- To view, visit http://gerrit.cloudera.org:8080/24190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea544b3c71d9211c893f0fec3527ebe84155ebcd Gerrit-Change-Number: 24190 Gerrit-PatchSet: 33 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: jichen <[email protected]> Gerrit-Comment-Date: Thu, 03 Sep 2026 23:12:58 +0000 Gerrit-HasComments: Yes
