Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24372 )
Change subject: IMPALA-15043: Add Kubernetes-in-Docker E2E scripts ...................................................................... Patch Set 50: Code-Review+2 (9 comments) http://gerrit.cloudera.org:8080/#/c/24372/47/bin/jenkins/all-tests.sh File bin/jenkins/all-tests.sh: http://gerrit.cloudera.org:8080/#/c/24372/47/bin/jenkins/all-tests.sh@110 PS47, Line 110: : : : : > Moved K8s E2E gate from Jenkins all-tests into bin/run-all-tests.sh as opt- Done http://gerrit.cloudera.org:8080/#/c/24372/47/bin/jenkins/run-k8s-e2e-tests.sh File bin/jenkins/run-k8s-e2e-tests.sh: http://gerrit.cloudera.org:8080/#/c/24372/47/bin/jenkins/run-k8s-e2e-tests.sh@1 PS47, Line 1: #!/usr/bin/env bash > Updated shebang, Done http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh File bin/run-k8s-e2e-tests.sh: http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh@23 PS47, Line 23: : "${IMPALA_HOME:=$(cd "${SCRIPT_DIR}/.." && pwd)}" > Changed to preserve existing IMPALA_HOME and only default if unset. Done http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh@24 PS47, Line 24: export IMPALA_HOME > Added cd "${IMPALA_HOME}". Done http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh@67 PS47, Line 67: > Switched HS2 readiness helper to impala-python3. Done http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh@131 PS47, Line 131: if [[ "${ready}" == "true" ]]; then : return 0 : fi > Reused cleanup() in failed port-forward path. Done http://gerrit.cloudera.org:8080/#/c/24372/47/bin/run-k8s-e2e-tests.sh@187 PS47, Line 187: TEST_CMD=( > Confirmed and retained passthrough support ("$@") to run-tests.py, validate Done http://gerrit.cloudera.org:8080/#/c/24372/47/helm/impala/README.md File helm/impala/README.md: http://gerrit.cloudera.org:8080/#/c/24372/47/helm/impala/README.md@407 PS47, Line 407: > Not a typo. The chart names services as <release-name>-impala-<component>, Done http://gerrit.cloudera.org:8080/#/c/24372/47/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/24372/47/tests/common/impala_test_suite.py@493 PS47, Line 493: cls.beeswax_client = cls.create_impala_client_internal(protocol=BEESWAX) > Reverted tests/common/impala_test_suite.py behavior changes and set ENABLE_ Done -- To view, visit http://gerrit.cloudera.org:8080/24372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I122b99c38c8c70ab535349f92212621330f2aa55 Gerrit-Change-Number: 24372 Gerrit-PatchSet: 50 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Mon, 10 Aug 2026 18:18:30 +0000 Gerrit-HasComments: Yes
