Jason Fehr has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24368 )
Change subject: IMPALA-15028: Add Helm chart render assertions ...................................................................... IMPALA-15028: Add Helm chart render assertions Add a lightweight CI-friendly chart test harness that runs helm lint, renders default and override manifests, and asserts key Impala Helm chart behaviors to prevent regressions. Wire chart checks into bin/run-all-tests.sh as an opt-in stage (HELM_CHART_TEST=false by default) and keep Jenkins all-tests behavior unchanged unless explicitly enabled. Cover both core defaults and optional chart functionality, including LDAP, Ranger, Kudu, OAuth, and secure-cluster Kerberos/TLS/Istio paths. Also validate required-value failures for secure secret inputs. Align assert script execution with repository conventions by using an executable shebang (#!/usr/bin/env impala-python3), invoking the script directly, and documenting required local dependencies. Testing: - bash -n bin/jenkins/all-tests.sh - bash -n bin/run-all-tests.sh - bash -n helm/impala/tests/run-chart-tests.sh - python3 bin/jenkins/critique-gerrit-review.py --dryrun Change-Id: I313be431e81a4b98370e51d298b7b2d35e0aded8 Assisted-by: GPT-5.3 (Cursor) Reviewed-on: http://gerrit.cloudera.org:8080/24368 Reviewed-by: Jason Fehr <[email protected]> Tested-by: Jason Fehr <[email protected]> --- M bin/run-all-tests.sh M helm/impala/README.md A helm/impala/tests/assert_chart.py A helm/impala/tests/run-chart-tests.sh 4 files changed, 784 insertions(+), 0 deletions(-) Approvals: Jason Fehr: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I313be431e81a4b98370e51d298b7b2d35e0aded8 Gerrit-Change-Number: 24368 Gerrit-PatchSet: 54 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]>
