Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 15: (1 comment) PS15: went through the three fixes on top of PS14. resolveSingleTable() and the qualifier-map cache look right to me; replies are in the PS14 threads. One follow-up there on the invertJoin() question, plus a small note below on the new LOG.trace. http://gerrit.cloudera.org:8080/#/c/24426/15/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24426/15/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@233 PS15, Line 233: LOG.trace("Expr {} references columns from different tables: {} and {}", expr.toSql() and both getFullName() calls are evaluated whether or not trace is enabled. canonicalizeExpr() runs per conjunct per strategy, and twice per node overall (lookup in computeStats(), store in toThrift()), so I would guard this with LOG.isTraceEnabled(). -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 15 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 10:08:24 +0000 Gerrit-HasComments: Yes
