Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 19: (3 comments) Addressed comments and refactored the code a bit for better reuse in follow-up patches. http://gerrit.cloudera.org:8080/#/c/24426/15/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24426/15/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@233 PS15, Line 233: if (LOG.isTraceEnabled()) { > expr.toSql() and both getFullName() calls are evaluated whether or not trac Done http://gerrit.cloudera.org:8080/#/c/24426/14/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/24426/14/fe/src/main/java/org/apache/impala/planner/JoinNode.java@1039 PS14, Line 1039: * "0", "0.1"). A single index suffices for a tuple that is its join's direct operand; > Fine by me on the group collection. Moved this to PlanNode so follow-up patches, e.g. the SortNode support patch, can use it. http://gerrit.cloudera.org:8080/#/c/24426/14/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/24426/14/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1050 PS14, Line 1050: * {@link #getHboOrderedOperands}. Defaults to children_ (e.g. UnionNode's operands are > invertJoin() is not restricted to directional joins. JoinOperator.invert() Ah, I misunderstood the meaning of invertJoin(). Thanks for the explanation! Added the comment. -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 19 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 19 Aug 2026 14:33:02 +0000 Gerrit-HasComments: Yes
