Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 )
Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/10758/9/be/src/kudu/util/kudu_export.h File be/src/kudu/util/kudu_export.h: http://gerrit.cloudera.org:8080/#/c/10758/9/be/src/kudu/util/kudu_export.h@17 PS9, Line 17: > No, I this is just manually added by us. Sorry, I may not have been clear. I noticed that this file doesn't exist in the Kudu code base either but it exists in various build directories. I didn't dig too much into the mechanism but I am just wondering if you happen to know why we need to copy it manually. -- To view, visit http://gerrit.cloudera.org:8080/10758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I451f02d3e4669e8a548b92fb1445cb2b322659a2 Gerrit-Change-Number: 10758 Gerrit-PatchSet: 9 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Tue, 10 Jul 2018 19:36:22 +0000 Gerrit-HasComments: Yes
