Michael Ho has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10758 )

Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.
......................................................................


Patch Set 9: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10758/9/be/src/kudu/util/kudu_export.h
File be/src/kudu/util/kudu_export.h:

http://gerrit.cloudera.org:8080/#/c/10758/9/be/src/kudu/util/kudu_export.h@17
PS9, Line 17:
> I understand. The file seems to be generated by Kudu's build through src/ku
A note would be good but feel free to merge it as-is. Just checking to see if 
we somehow auto-generate it on Impala side too. Guess not.



--
To view, visit http://gerrit.cloudera.org:8080/10758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I451f02d3e4669e8a548b92fb1445cb2b322659a2
Gerrit-Change-Number: 10758
Gerrit-PatchSet: 9
Gerrit-Owner: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Jul 2018 01:52:43 +0000
Gerrit-HasComments: Yes

Reply via email to