Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24614 )
Change subject: IMPALA-12587: Respect MAX_FS_WRITERS for Iceberg DELETE/UPDATE/MERGE ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24614/3/fe/src/main/java/org/apache/impala/planner/InstanceCountProvidingSink.java File fe/src/main/java/org/apache/impala/planner/InstanceCountProvidingSink.java: http://gerrit.cloudera.org:8080/#/c/24614/3/fe/src/main/java/org/apache/impala/planner/InstanceCountProvidingSink.java@31 PS3, Line 31: /** It might have an another method that just returns the max number of allowed writers and the 'getNumInstances' could get a default implementation that calls this method. http://gerrit.cloudera.org:8080/#/c/24614/3/fe/src/test/java/org/apache/impala/planner/IcebergWriterLimitTest.java File fe/src/test/java/org/apache/impala/planner/IcebergWriterLimitTest.java: http://gerrit.cloudera.org:8080/#/c/24614/3/fe/src/test/java/org/apache/impala/planner/IcebergWriterLimitTest.java@47 PS3, Line 47: public class IcebergWriterLimitTest extends PlannerTestBase { This test should be a *.test file instead in the PlannerTest and just a function call in the PlannerTest.java. testHdfsInsertWriterLimit in PlannerTest.java could help. -- To view, visit http://gerrit.cloudera.org:8080/24614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice7362cecb8b43fbff43b8ad82827e31e2b4eea3 Gerrit-Change-Number: 24614 Gerrit-PatchSet: 3 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2026 12:08:22 +0000 Gerrit-HasComments: Yes
