Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24614 )
Change subject: IMPALA-12587: Respect MAX_FS_WRITERS for Iceberg DELETE/UPDATE/MERGE ...................................................................... Patch Set 7: Code-Review+1 (2 comments) Please add e2e tests that explicitly validates the number of written files; TestInsertHdfsWriterLimit in tests/query_test/test_insert.py could help, maybe it's better to add similar tests to test_iceberg.py http://gerrit.cloudera.org:8080/#/c/24614/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24614/7//COMMIT_MSG@18 PS7, Line 18: InstanceCountProvidingSink nit: stale http://gerrit.cloudera.org:8080/#/c/24614/7/fe/src/main/java/org/apache/impala/planner/MultiDataSink.java File fe/src/main/java/org/apache/impala/planner/MultiDataSink.java: http://gerrit.cloudera.org:8080/#/c/24614/7/fe/src/main/java/org/apache/impala/planner/MultiDataSink.java@55 PS7, Line 55: icpSink nit:hasLimitSink? -- To view, visit http://gerrit.cloudera.org:8080/24614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice7362cecb8b43fbff43b8ad82827e31e2b4eea3 Gerrit-Change-Number: 24614 Gerrit-PatchSet: 7 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 11:37:14 +0000 Gerrit-HasComments: Yes
