Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24736 )
Change subject: IMPALA-11577: optimize file format counting ...................................................................... Patch Set 1: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24736/1/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/24736/1/common/thrift/CatalogObjects.thrift@677 PS1, Line 677: 5: optional set<TIcebergFileFormat> file_formats Renaming field 'has_avro' to 'file_formats' in TIcebergContentFileStore might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/24736/1/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java File fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java: http://gerrit.cloudera.org:8080/#/c/24736/1/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@230 PS1, Line 230: private EnumSet<TIcebergFileFormat> fileFormats_ = EnumSet.noneOf(TIcebergFileFormat.class); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24736/1/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@685 PS1, Line 685: ret.fileFormats_ = tFileStore.isSetFile_formats() && !tFileStore.getFile_formats().isEmpty() ? line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/24736/1/fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java@686 PS1, Line 686: EnumSet.copyOf(tFileStore.getFile_formats()) : EnumSet.noneOf(TIcebergFileFormat.class); line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3956c72559d562d6a0a8e163042e3ded6cc0c627 Gerrit-Change-Number: 24736 Gerrit-PatchSet: 1 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2026 15:16:14 +0000 Gerrit-HasComments: Yes
