Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24736 )
Change subject: IMPALA-11577: optimize file format counting ...................................................................... Patch Set 3: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24736/3/fe/src/test/java/org/apache/impala/catalog/IcebergContentFileStoreTest.java File fe/src/test/java/org/apache/impala/catalog/IcebergContentFileStoreTest.java: http://gerrit.cloudera.org:8080/#/c/24736/3/fe/src/test/java/org/apache/impala/catalog/IcebergContentFileStoreTest.java@93 PS3, Line 93: verifyPerContainerFileFormats("iceberg_v2_partitioned_position_deletes_orc", TIcebergFileFormat.ORC); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/24736/3/fe/src/test/java/org/apache/impala/catalog/IcebergContentFileStoreTest.java@94 PS3, Line 94: verifyPerContainerFileFormats("iceberg_v2_partitioned_position_deletes", TIcebergFileFormat.PARQUET); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/24736/3/fe/src/test/java/org/apache/impala/catalog/IcebergContentFileStoreTest.java@113 PS3, Line 113: private void verifyPerContainerFileFormats(String tableName, TIcebergFileFormat expectedFileFormat) throws Exception { line too long (120 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3956c72559d562d6a0a8e163042e3ded6cc0c627 Gerrit-Change-Number: 24736 Gerrit-PatchSet: 3 Gerrit-Owner: Nandor Kollar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 16 Sep 2026 14:04:22 +0000 Gerrit-HasComments: Yes
