Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24559 )
Change subject: IMPALA-12700: Take Iceberg Parquet Bloom filter properties into account ...................................................................... Patch Set 5: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24559/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/24559/4/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@483 PS4, Line 483: // The properties are validated at CREATE/ALTER time, so this is not expected. > Should this be a precondition? Other engines might still set invalid properties. Updated the write paths (INSERT, UPDATE, MERGE) to warn the user if the properties are invalid. http://gerrit.cloudera.org:8080/#/c/24559/4/tests/query_test/test_parquet_bloom_filter.py File tests/query_test/test_parquet_bloom_filter.py: http://gerrit.cloudera.org:8080/#/c/24559/4/tests/query_test/test_parquet_bloom_filter.py@422 PS4, Line 422: "'write.parquet.bloom-filter-enabled.column.s'='true'," > What happens if you try to set this higher than Impala's max (I think 128Mi It is clamped to 128 MiB in IcebergUtil. Added tests for it. -- To view, visit http://gerrit.cloudera.org:8080/24559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7baab79bbc055ddc8e2b05bbbc7083e02dc914e Gerrit-Change-Number: 24559 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 08:44:36 +0000 Gerrit-HasComments: Yes
