Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24559 )
Change subject: IMPALA-12700: Take Iceberg Parquet Bloom filter properties into account ...................................................................... Patch Set 6: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24559/5/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java: http://gerrit.cloudera.org:8080/#/c/24559/5/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@118 PS5, Line 118: IcebergUtil.warnIfInvalidParquetBloomFilterProperties(icebergTable_, analyzer); : int formatVersion = icebergTable_.getFormatVersion(); : if (formatVersion > Iceber > IMO this comment is redundant. The comment above the implementation in Iceb Removed, done. http://gerrit.cloudera.org:8080/#/c/24559/5/fe/src/main/java/org/apache/impala/analysis/IcebergUpdateImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergUpdateImpl.java: http://gerrit.cloudera.org:8080/#/c/24559/5/fe/src/main/java/org/apache/impala/analysis/IcebergUpdateImpl.java@87 PS5, Line 87: IcebergUtil.warnIfInvalidParquetBloomFilterProperties(originalTargetTable_, analyzer); : } > IMO this comment is redundant. The comment above the implementation in Iceb Removed, done. http://gerrit.cloudera.org:8080/#/c/24559/5/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/24559/5/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@884 PS5, Line 884: : > nit: this character (';') is a semicolon. Did you mean (':')? Nice catch! Done. -- To view, visit http://gerrit.cloudera.org:8080/24559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7baab79bbc055ddc8e2b05bbbc7083e02dc914e Gerrit-Change-Number: 24559 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 13:54:51 +0000 Gerrit-HasComments: Yes
