Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/24426/24/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24426/24/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@191 PS24, Line 191: * source-expr chain. > A materialized expression can lose its operand qualifiers here. `SortInfo` Nice catch! I'm able to reproduce the issue using an Aggregation over Join: select coalesce(a.id, b.int_col), count(*) from functional.alltypes a join functional.alltypestiny b on a.id = b.id group by coalesce(a.id, b.int_col); I can see the HBO key string has "coalesce(id, int_col)" which is missing the qualifiers. Fixed the issue by qualifying the SlotRefs in source expressions recursively. -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 26 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2026 09:07:17 +0000 Gerrit-HasComments: Yes
