Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 28: (4 comments) http://gerrit.cloudera.org:8080/#/c/24426/24/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24426/24/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@191 PS24, Line 191: CanonicalizationStrategy strategy) { I think the visited set can be removed. It's just a defensive guard. There are other codes like Expr.findSrcExpr() that just ignore cycle reference. > Would a swapped ORDER BY coalesce(...) case for SortNode, and the analytic > one, be worth adding? That is the path the collision came from. The current patch doesn't support HBO on SortNode or AnalyticEvalNodde yet. We can add such tests in follow-up patches. http://gerrit.cloudera.org:8080/#/c/24426/27/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java File fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java: http://gerrit.cloudera.org:8080/#/c/24426/27/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@22 PS27, Line 22: import java.util.List; > unused import: java.util.HashSet Done http://gerrit.cloudera.org:8080/#/c/24426/27/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@25 PS27, Line 25: import org.apache.impala.analysis.BinaryPredicate; > unused import: java.util.Set Done http://gerrit.cloudera.org:8080/#/c/24426/27/fe/src/main/java/org/apache/impala/planner/ExprCanonicalizer.java@32 PS27, Line 32: import org.apache.impala.analysis.TupleDescriptor; > unused import: org.apache.impala.analysis.SlotId Done -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 28 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2026 12:40:29 +0000 Gerrit-HasComments: Yes
