Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24785 )
Change subject: IMPALA-15323: Produce Ranger audit events for CREATE/DROP ROLE ...................................................................... Patch Set 1: (10 comments) Hi all, please let me know if there is any comment on the patch. Thanks very much for the help! http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java File fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java: http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@106 PS1, Line 106: "create" It's better to use a variable to store the value of this string. http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@106 PS1, Line 106: "CREATE" It's better to use a variable to store the value of this string. http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@114 PS1, Line 114: "CREATE" It's better to use a variable to store the value of this string. http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@114 PS1, Line 114: "create" It's better to use a variable to store the value of this string. http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@134 PS1, Line 134: "DROP" It's better to use a variable to store the value of this string. http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@134 PS1, Line 134: "drop" It's better to use a variable to store the value of this string. http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@142 PS1, Line 142: "DROP" It's better to use a variable to store the value of this string. http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@142 PS1, Line 142: "drop" It's better to use a variable to store the value of this string. http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@229 PS1, Line 229: Lines 229 and 230 are not needed. http://gerrit.cloudera.org:8080/#/c/24785/1/fe/src/test/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManagerTest.java@270 PS1, Line 270: 'role' nit: a role 'role'. -- To view, visit http://gerrit.cloudera.org:8080/24785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3fcfe0dcf54041aca57ed66ddef95b0ddd15b6fb Gerrit-Change-Number: 24785 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2026 23:16:00 +0000 Gerrit-HasComments: Yes
