Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24785 )
Change subject: IMPALA-15323: Produce Ranger audit events for CREATE/DROP ROLE ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/24785/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/24785/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@89 PS2, Line 89: public static final String DROP_ROLE_ACTION = "DROPROLE"; Do we need underscores here, i.e. "CREATE_ROLE", "DROP_ROLE"? Are these strings defined in Ranger? http://gerrit.cloudera.org:8080/#/c/24785/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@106 PS2, Line 106: Preconditions.checkNotNull(requestingUser); 'requestingUser' won't be null here. We should check header.isSetRequesting_user() above. http://gerrit.cloudera.org:8080/#/c/24785/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/24785/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@469 PS2, Line 469: if (header.isSetRequesting_user()) { : requestingUser = new User(ddlRequest.getHeader().getRequesting_user()); : } This can be removed now. -- To view, visit http://gerrit.cloudera.org:8080/24785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3fcfe0dcf54041aca57ed66ddef95b0ddd15b6fb Gerrit-Change-Number: 24785 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 08 Sep 2026 12:53:20 +0000 Gerrit-HasComments: Yes
