Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 )
Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1059 PS1, Line 1059: ALL I think this should stay SELECT since that is the only privilege we allow on columns. If we're looking to future proof, then it should just be the metadata privileges. http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1086 PS1, Line 1086: ALL Same as above http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1134 PS1, Line 1134: ALL same as above http://gerrit.cloudera.org:8080/#/c/10923/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1145 PS1, Line 1145: ALL same as above -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Jul 2018 19:25:22 +0000 Gerrit-HasComments: Yes
