Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 )
Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/10923/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10923/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1065 PS2, Line 1065: checkStrings = > doesn't look like this is used any longer except for L1066 (next line). inl Done http://gerrit.cloudera.org:8080/#/c/10923/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@1076 PS2, Line 1076: > why is this null now? perhaps clarify with a comment. Done -- To view, visit http://gerrit.cloudera.org:8080/10923 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37d1610a922741a6c95059c3beb7d04eb507783f Gerrit-Change-Number: 10923 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Jul 2018 23:48:59 +0000 Gerrit-HasComments: Yes
