Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24190 )
Change subject: IMPALA-14882: part1: Convert arrow record batch to impala tuple batch ...................................................................... Patch Set 35: (4 comments) Thanks for the comments. There were also some minor issues in arrow-converter-benchmark.cc that I fixed. http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/benchmarks/arrow-converter-benchmark.cc File be/src/benchmarks/arrow-converter-benchmark.cc: http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/benchmarks/arrow-converter-benchmark.cc@48 PS33, Line 48: // Mixed 271 277 281 0.238X 0.237X 0.234X > This primarily shows Mixed is slower. Added an arrow to arrow copy suite for comparison. http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/benchmarks/arrow-converter-benchmark.cc@116 PS33, Line 116: const std::shared_ptr<arrow::ArrayData>& array_data = > nit: excess whitespace Done http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/exec/arrow-converter.cc File be/src/exec/arrow-converter.cc: http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/exec/arrow-converter.cc@54 PS33, Line 54: RETURN_IF_ERROR(WriteSlotBatch(arr.get(), 0, num_rows, slot_desc, > Have you benchmarked operating on a batch of tuple_mems and writing a colum I don't understand what you mean exactly. Columns are written one by one during this conversion into a pre-allocated tuple_mem. The arrow-converter-benchmark.cc calls this same conversion. http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/exec/paimon/CMakeLists.txt File be/src/exec/paimon/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24190/33/be/src/exec/paimon/CMakeLists.txt@a25 PS33, Line 25: > Should the file itself also be removed? Done -- To view, visit http://gerrit.cloudera.org:8080/24190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea544b3c71d9211c893f0fec3527ebe84155ebcd Gerrit-Change-Number: 24190 Gerrit-PatchSet: 35 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: jichen <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 10:26:57 +0000 Gerrit-HasComments: Yes
