Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24612 )
Change subject: IMPALA-15179: Support HBO for SelectNode cardinality ...................................................................... Patch Set 7: (3 comments) > it may be worth hoisting the `limit:` component into shared code, e.g. the > generateHboHashStrings() wrapper appending it for every node, in the spirit > of Steve's polymorphism comment on 24608. That's a good point. Added a method in the JoinNode patch: https://gerrit.cloudera.org/c/24426/30..31/fe/src/main/java/org/apache/impala/planner/PlanNode.java http://gerrit.cloudera.org:8080/#/c/24612/4/fe/src/main/java/org/apache/impala/planner/SelectNode.java File fe/src/main/java/org/apache/impala/planner/SelectNode.java: http://gerrit.cloudera.org:8080/#/c/24612/4/fe/src/main/java/org/apache/impala/planner/SelectNode.java@158 PS4, Line 158: getDisplayLabel(), getChild(0).getDisplayLabel()); > limit_ is missing from the key, and a SelectNode can carry one: for a state Done http://gerrit.cloudera.org:8080/#/c/24612/4/fe/src/main/java/org/apache/impala/planner/SelectNode.java@170 PS4, Line 170: List<String> predStrs = ExprCanonicalizer.canonicalizeExprs( > Why hardcode EXPR_REWRITE here instead of passing `strategy` through, as Jo Done http://gerrit.cloudera.org:8080/#/c/24612/5/fe/src/main/java/org/apache/impala/planner/SelectNode.java File fe/src/main/java/org/apache/impala/planner/SelectNode.java: http://gerrit.cloudera.org:8080/#/c/24612/5/fe/src/main/java/org/apache/impala/planner/SelectNode.java@77 PS5, Line 77: computeHboOperandQualifierMap(analyzer); > `SelectNode` copies all tuple ids from its child, but this custom `init()` Done -- To view, visit http://gerrit.cloudera.org:8080/24612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5804f9ebf9e06a4947ea3e11441c63e89c82e036 Gerrit-Change-Number: 24612 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 06 Sep 2026 08:57:10 +0000 Gerrit-HasComments: Yes
