Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24612 )
Change subject: IMPALA-15179: Support HBO for SelectNode cardinality ...................................................................... Patch Set 6: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24612/6/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java File fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java: http://gerrit.cloudera.org:8080/#/c/24612/6/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@1634 PS6, Line 1634: String keyFmt = "CARDINALITY:SelectNode:|Predicates:[rank() OVER (PARTITION BY int_col" line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24612/6/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@1691 PS6, Line 1691: String expected1 = "CARDINALITY:SelectNode:|Predicates:[op1.id > op0.int_col]" + childKey; line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24612/6/fe/src/test/java/org/apache/impala/planner/HboKeyStringTest.java@1692 PS6, Line 1692: String expected2 = "CARDINALITY:SelectNode:|Predicates:[op0.id > op1.int_col]" + childKey; line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24612 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5804f9ebf9e06a4947ea3e11441c63e89c82e036 Gerrit-Change-Number: 24612 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 06 Sep 2026 08:55:01 +0000 Gerrit-HasComments: Yes
