Xuebin Su has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23709 )

Change subject: IMPALA-13552: Add support for size()/length() for array/map 
types
......................................................................


Patch Set 4:

(2 comments)

Hi!

http://gerrit.cloudera.org:8080/#/c/23709/4/be/src/exprs/anyval-util.h
File be/src/exprs/anyval-util.h:

http://gerrit.cloudera.org:8080/#/c/23709/4/be/src/exprs/anyval-util.h@210
PS4, Line 210:         return sizeof(CollectionVal);
Why is CollectionVal used in the TYPE_STRUCT case?


http://gerrit.cloudera.org:8080/#/c/23709/4/be/src/exprs/anyval-util.h@238
PS4, Line 238:         return alignof(CollectionVal);
Why is CollectionVal used in the TYPE_STRUCT case?



--
To view, visit http://gerrit.cloudera.org:8080/23709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I85b50386790657ea035addb35eed959d71810ab2
Gerrit-Change-Number: 23709
Gerrit-PatchSet: 4
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Wed, 09 Sep 2026 07:07:39 +0000
Gerrit-HasComments: Yes

Reply via email to