Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23709 )
Change subject: IMPALA-13552: Add support for size()/length() for array/map types ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/23709/4/be/src/exprs/anyval-util.h File be/src/exprs/anyval-util.h: http://gerrit.cloudera.org:8080/#/c/23709/4/be/src/exprs/anyval-util.h@210 PS4, Line 210: case TYPE_MAP: > Why is CollectionVal used in the TYPE_STRUCT case? the decision was driven by collection-function support (TYPE_ARRAY / TYPE_MAP), and TYPE_STRUCT was folded in without switching to StructVal. Changed it to StructVal for consistency. http://gerrit.cloudera.org:8080/#/c/23709/4/be/src/exprs/anyval-util.h@238 PS4, Line 238: case TYPE_DATE: return alignof(DateVal); > Why is CollectionVal used in the TYPE_STRUCT case? Done -- To view, visit http://gerrit.cloudera.org:8080/23709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85b50386790657ea035addb35eed959d71810ab2 Gerrit-Change-Number: 23709 Gerrit-PatchSet: 6 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Wed, 09 Sep 2026 18:49:31 +0000 Gerrit-HasComments: Yes
