Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24633 )
Change subject: IMPALA-15222: Short-circuit OPTIMIZE when the table is compact ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24633/3/fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java File fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java: http://gerrit.cloudera.org:8080/#/c/24633/3/fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java@49 PS3, Line 49: public static FileFilteringResult noOp() { nit: instead of a method, I think you can simply use a constant: private static final FileFilteringResult NO_OP_RESULT = new FileFilteringResult(null, Collections.emptyList()); -- To view, visit http://gerrit.cloudera.org:8080/24633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I795967ca18231ef1fefdbc71a9b4505905906f95 Gerrit-Change-Number: 24633 Gerrit-PatchSet: 3 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 15:11:03 +0000 Gerrit-HasComments: Yes
