Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24633 )
Change subject: IMPALA-15222: Short-circuit OPTIMIZE when the table is compact ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/24633/3/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/24633/3/common/thrift/Query.thrift@a1043 PS3, Line 1043: > Removing the enum item TIcebergOptimizationMode.NOOP=2 might break the comp Catalog version will be incremented to mark accumulated breaking changes. http://gerrit.cloudera.org:8080/#/c/24633/3/fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java File fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java: http://gerrit.cloudera.org:8080/#/c/24633/3/fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java@49 PS3, Line 49: private static final FileFilteringResult NO_OP_RESULT = > Actually then you can also rewrite isNoOp() to 'return this == FileFilterin Good idea, thanks. http://gerrit.cloudera.org:8080/#/c/24633/3/fe/src/main/java/org/apache/impala/util/IcebergOptimizeFileFilter.java@49 PS3, Line 49: private static final FileFilteringResult NO_OP_RESULT = > nit: instead of a method, I think you can simply use a constant: Done -- To view, visit http://gerrit.cloudera.org:8080/24633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I795967ca18231ef1fefdbc71a9b4505905906f95 Gerrit-Change-Number: 24633 Gerrit-PatchSet: 4 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sun, 13 Sep 2026 17:50:09 +0000 Gerrit-HasComments: Yes
