Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24682 )
Change subject: IMPALA-15310: Finalize REST catalog INSERT ...................................................................... Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/24682/13/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/24682/13/be/src/service/client-request-state.cc@1784 PS13, Line 1784: query_events_->MarkEvent("DML Metastore update finished"); > I think no metastore is involved in this finalization. Fixed in PS14: timeline and OTel events now refer to the REST catalog commit. http://gerrit.cloudera.org:8080/#/c/24682/13/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java: http://gerrit.cloudera.org:8080/#/c/24682/13/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@216 PS13, Line 216: getIcebergDmlCatalogName > nit: getIcebergCatalogName? I'd keep `getIcebergDmlCatalogName()`: it's a DML routing name, null for empty or duplicate names to disable INSERT INTO. http://gerrit.cloudera.org:8080/#/c/24682/13/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/24682/13/fe/src/main/java/org/apache/impala/service/Frontend.java@652 PS13, Line 652: public void finalizeIcebergDml(TIcebergDmlFinalizeRequest request) > can we move it to IcebergDmlFinalizer? Moved to `IcebergDmlFinalizer` in PS14; `Frontend` now only delegates the JNI call. -- To view, visit http://gerrit.cloudera.org:8080/24682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d17216fb8d12e5bd007b93cb9b3bc153438213b Gerrit-Change-Number: 24682 Gerrit-PatchSet: 13 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 05:33:15 +0000 Gerrit-HasComments: Yes
