Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24682 )
Change subject: IMPALA-15310: Finalize REST catalog INSERT ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/24682/12/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/24682/12/fe/src/main/java/org/apache/impala/service/Frontend.java@668 PS12, Line 668: if (!(table instanceof FeIcebergTable)) { : throw new ImpalaRuntimeException(String.format( : "DML finalization target is not an Iceberg table: %s.%s", : request.getDb_name(), request.getTarget_table())); : } : : iceTbl = (FeIcebergTable)table; : if (!catalogName.equals(iceTbl.getIcebergDmlCatalogName())) { : throw new ImpalaRuntimeException(String.format( : "REST catalog changed for table %s.%s", : request.getDb_name(), request.getTarget_table())); : } > nit: could be moved to a new method called 'validateRestTargetTable()' Moved this to validateRestTargetTable() in PS13. http://gerrit.cloudera.org:8080/#/c/24682/12/tests/custom_cluster/test_iceberg_rest_catalog.py File tests/custom_cluster/test_iceberg_rest_catalog.py: http://gerrit.cloudera.org:8080/#/c/24682/12/tests/custom_cluster/test_iceberg_rest_catalog.py@286 PS12, Line 286: unsupported_statements = [ > Can we test TRUNCATE as well? Added TRUNCATE coverage and fixed its REST capability check in PS13. -- To view, visit http://gerrit.cloudera.org:8080/24682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d17216fb8d12e5bd007b93cb9b3bc153438213b Gerrit-Change-Number: 24682 Gerrit-PatchSet: 12 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 18:27:13 +0000 Gerrit-HasComments: Yes
