Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/24557 )
Change subject: IMPALA-15057: Add variant_get() builtin and first-class VARIANT expressions ...................................................................... Patch Set 9: Code-Review+1 (1 comment) LGTM http://gerrit.cloudera.org:8080/#/c/24557/7/be/src/exprs/variant-functions-test.cc File be/src/exprs/variant-functions-test.cc: http://gerrit.cloudera.org:8080/#/c/24557/7/be/src/exprs/variant-functions-test.cc@198 PS7, Line 198: EXPECT_FALSE(s.is_null); > We usually place member fields last in C++ classes. I see, but it's apart from the tracker_, pool_ and ctx_ -- To view, visit http://gerrit.cloudera.org:8080/24557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55bfed394ac2fb57135fadedd489f59e4cc10de4 Gerrit-Change-Number: 24557 Gerrit-PatchSet: 9 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 15 Sep 2026 12:52:57 +0000 Gerrit-HasComments: Yes
