Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24557 )
Change subject: IMPALA-15057: Add variant_get() builtin and first-class VARIANT expressions ...................................................................... Patch Set 11: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24557/10/be/src/runtime/variant-value.cc File be/src/runtime/variant-value.cc: http://gerrit.cloudera.org:8080/#/c/24557/10/be/src/runtime/variant-value.cc@424 PS10, Line 424: while (p < end && *p >= '0' && *p <= '9') { > Integer overflow on [100000000000000000000] Good catch, done. http://gerrit.cloudera.org:8080/#/c/24557/10/be/src/util/variant-util.h File be/src/util/variant-util.h: http://gerrit.cloudera.org:8080/#/c/24557/10/be/src/util/variant-util.h@48 PS10, Line 48: } // namespace impala > nit: it's not used anymore Thanks, removed. -- To view, visit http://gerrit.cloudera.org:8080/24557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55bfed394ac2fb57135fadedd489f59e4cc10de4 Gerrit-Change-Number: 24557 Gerrit-PatchSet: 11 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 16 Sep 2026 19:23:18 +0000 Gerrit-HasComments: Yes
