Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/24590 )
Change subject: IMPALA-9821: Change DataSketches functions to return BINARY ...................................................................... Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/24590/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24590/3//COMMIT_MSG@9 PS3, Line 9: Currently Impala returns a STRING value for > Is it just ORC? I assumed that this has nothing to do with file format, the While the change is global, the type discrepancy was resulting in error only for ORC (see Jira ticket) due to stricter type system. It was fixed partially in your IMPALA-9482 and fully now. See also `datasketches-hll-hive-orc.test`. Added some elaboration to make it clear. http://gerrit.cloudera.org:8080/#/c/24590/3//COMMIT_MSG@61 PS3, Line 61: la > As above, is it just ORC? See answer above. Here it is suitable I think. http://gerrit.cloudera.org:8080/#/c/24590/3//COMMIT_MSG@74 PS3, Line 74: Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25 > nit: I think that this is redundant, we should assume that tests passed in Ack http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-cpc.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-cpc.test: http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-cpc.test@142 PS3, Line 142: ==== > see my comment in https://gerrit.cloudera.org/#/c/24590/3/testdata/workload Done here too -- see my reply on datasketches-theta.test. Restored the runtime deserialize checks via CAST(... AS BINARY), alongside the new analysis-rejection checks. http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test: http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test@5 PS3, Line 5: ections > I don't think that this is needed, the passed unique_database is used by de It doesn't seem to be the case for HIVE_QUERY's. Removed for regular ones though. http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test: http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll.test@141 PS3, Line 141: ---- QUERY > see my comment in https://gerrit.cloudera.org/#/c/24590/3/testdata/workload Done here too -- see my reply on datasketches-theta.test. Restored the runtime deserialize checks via CAST(... AS BINARY), alongside the new analysis-rejection checks. http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test: http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-kll.test@6 PS3, Line 6: AnalysisException: No matching function with signature: ds_kll_quantile(STRING, DECIMAL(1,1)) > See my comment in https://gerrit.cloudera.org/#/c/24590/3/testdata/workload Done here too -- see my reply on datasketches-theta.test. Restored the runtime deserialize checks via CAST(... AS BINARY), alongside the new analysis-rejection checks. http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test: http://gerrit.cloudera.org:8080/#/c/24590/3/testdata/workloads/functional-query/queries/QueryTest/datasketches-theta.test@a208 PS3, Line 208: : : : > Why was this removed? Could still work after casting to BINARY. My bad. I misinterpreted these for just wrong type checks that now are catched by AnalysisException. But these are checking the malformed sketches, which we should keep. I've also tried to reduce some other unnecessary changes in the .test files. http://gerrit.cloudera.org:8080/#/c/24590/3/tests/query_test/test_datasketches.py File tests/query_test/test_datasketches.py: http://gerrit.cloudera.org:8080/#/c/24590/3/tests/query_test/test_datasketches.py@26 PS3, Line 26: _SKETCH_COLS_9 = ('ti binary, i binary, bi binary, f binary, d binary, ' > Not in the scope of this batch, but it could be useful to have a query opti Filed IMPALA-15329. -- To view, visit http://gerrit.cloudera.org:8080/24590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25 Gerrit-Change-Number: 24590 Gerrit-PatchSet: 4 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 17 Sep 2026 11:07:22 +0000 Gerrit-HasComments: Yes
