Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24590 )
Change subject: IMPALA-9821: Change DataSketches functions to return BINARY ...................................................................... Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24590/8/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test File testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test: http://gerrit.cloudera.org:8080/#/c/24590/8/testdata/workloads/functional-query/queries/QueryTest/datasketches-hll-hive-orc.test@3 PS8, Line 3: # IMPALA-9821: Hive's ds_hll_sketch() returns BINARY and writes BINARY to ORC and HMS. : # After the fix, Impala's ds_hll_estimate() must accept BINARY input. : # HIVE_QUERY sections run in a fresh Hive session with no 'use_db', so the table : # must be qualified with $DATABASE to land in the test's unique database. nit: this comment could be less verbose, like there's no added value to mention the $DATABASE reference, and the ticket ID at the start. This is also true to the above statements. -- To view, visit http://gerrit.cloudera.org:8080/24590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25 Gerrit-Change-Number: 24590 Gerrit-PatchSet: 8 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 21 Sep 2026 08:19:53 +0000 Gerrit-HasComments: Yes
