Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() ...................................................................... Patch Set 1: > > I am not sure what kind of tests I can add to this, since this > > looks more like an abuse of API than an actual functionality that > i > > can test. any ideas welcomed > > How about the test case that repro'd this? I mean the one Balasz > posted? I can, but i am wondering if its worth adding a test case that tests a very specific bug. Like if someone where to add similar code to there nodes/code paths, the added test wont be able to catch that. -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 12 Jul 2018 22:54:49 +0000 Gerrit-HasComments: No
