Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10933 )
Change subject: IMPALA-7288: Fix Codegen Crash in FinalizeModule() ...................................................................... IMPALA-7288: Fix Codegen Crash in FinalizeModule() Currently codegen crashed during FinalizeModule() where it tries to clean up half-baked handcrafted functions. This happens only for the cases where the code generating the handcrafted IR calls eraseFromParent() on failure which also deletes the memory held by the function pointer and therefore causes a crash during clean up in FinalizeModule(). Testing: Added regression tests that verify that failure code paths in the previously offending methods don't crash Impala. Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Reviewed-on: http://gerrit.cloudera.org:8080/10933 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/exec/hash-table.cc M be/src/exec/hdfs-avro-scanner.cc M be/src/exec/hdfs-scanner.cc M tests/query_test/test_codegen.py 4 files changed, 17 insertions(+), 4 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/10933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2f0b527909a9fb3090996bb7510e4d58350c21b0 Gerrit-Change-Number: 10933 Gerrit-PatchSet: 4 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>