Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24965 )
Change subject: IMPALA-13965: Enforce quotas without executors ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/24965/5/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/24965/5/be/src/scheduling/admission-controller.cc@1482 PS5, Line 1482: PoolStats* pool_stats = GetPoolStats(pool_name); According to admission-controller.h, callers of this overload of GetPoolStatus must hold the admission_ctrl_lock_. This lock is not held in either execution path. This is a pre-existing issue that should be corrected by taking ownership of admission_ctrl_lock_ only while calling GetPoolStats. -- To view, visit http://gerrit.cloudera.org:8080/24965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84024a8d11911b639679029e34445ca52902ab93 Gerrit-Change-Number: 24965 Gerrit-PatchSet: 5 Gerrit-Owner: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Anubhav Jindal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Tue, 29 Sep 2026 22:38:17 +0000 Gerrit-HasComments: Yes
