Hello Abhishek Rawat, Jason Fehr, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24965
to look at the new patch set (#6).
Change subject: IMPALA-13965: Enforce quotas without executors
......................................................................
IMPALA-13965: Enforce quotas without executors
Admission could return early when no executor group was available.
That skipped quota rejection on submission and let queued requests
overflow user limits until executors came online. This change enforces
quota in the empty-group path and tracks queued user-load ownership.
Reject, timeout, and cancel paths now decrement per-user load exactly
once.
Adds regression coverage in admission-controller unit tests and
custom-cluster executor-group tests for both no-executor quota
enforcement and queued-timeout load cleanup.
Testing:
- Built: impalad, statestored, catalogd, admission-controller-test
- Ran: admission-controller-test (UserAndGroupQuotas, PoolStats)
- Ran: tests/custom_cluster/test_executor_groups.py with focused -k
filter for quota-without-executors and queued-timeout-release
coverage
- Performed manual STR validation from IMPALA-13965 and verified
quotas are enforced correctly once executors join.
Change-Id: I84024a8d11911b639679029e34445ca52902ab93
Assisted-by: GPT-5.3 (Cursor)
---
M be/src/scheduling/admission-controller-test.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M tests/custom_cluster/test_executor_groups.py
4 files changed, 171 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/24965/6
--
To view, visit http://gerrit.cloudera.org:8080/24965
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84024a8d11911b639679029e34445ca52902ab93
Gerrit-Change-Number: 24965
Gerrit-PatchSet: 6
Gerrit-Owner: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Anubhav Jindal <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
