Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24989 )
Change subject: IMPALA-14778: Fix Close() crashes in Iceberg metadata and Paimon scans ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24989/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.h File be/src/exec/iceberg-metadata/iceberg-metadata-scanner.h: http://gerrit.cloudera.org:8080/#/c/24989/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.h@82 PS1, Line 82: /// Removes global references. Safe to call if Init() failed or was not called. What about jtable_? http://gerrit.cloudera.org:8080/#/c/24989/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc File be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24989/1/be/src/exec/iceberg-metadata/iceberg-metadata-scanner.cc@262 PS1, Line 262: jmetadata_scanner_ = nullptr; Isn't jtable_ a leaked global ref? We could delete it here, too. http://gerrit.cloudera.org:8080/#/c/24989/1/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java File fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java: http://gerrit.cloudera.org:8080/#/c/24989/1/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java@67 PS1, Line 67: // Persist the file scan task iterator so we can continue after a RowBatch is full : private CloseableIterator<FileScanTask> fileScanTaskIterator_; : : // Persist the data rows iterator, so we can continue after a batch is filled : private CloseableIterator<StructLike> dataRowsIterator_; Both CloseableIterators wrap Iceberg manifest/Avro readers and are never closed. This class has no close(), so IcebergMetadataScanner::Close() has nothing to call (contrast PaimonJniScanner::Close(), which does call the Java close()). We could add a close() that closes both. -- To view, visit http://gerrit.cloudera.org:8080/24989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0519035ecdca966bdc1a26147a157dc62bad2d8f Gerrit-Change-Number: 24989 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Fri, 02 Oct 2026 13:58:25 +0000 Gerrit-HasComments: Yes
