Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24989 )
Change subject: IMPALA-14778: Fix Close() crashes in Iceberg metadata and Paimon scans ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Nice fix, thanks! I only have some nits. http://gerrit.cloudera.org:8080/#/c/24989/3/be/src/exec/paimon/paimon-jni-scanner.cc File be/src/exec/paimon/paimon-jni-scanner.cc: http://gerrit.cloudera.org:8080/#/c/24989/3/be/src/exec/paimon/paimon-jni-scanner.cc@95 PS3, Line 95: env->CallObjectMethod(j_jni_scanner_, paimon_jni_scanner_close_); The Iceberg side goes through JniCall (which clears the exception via RETURN_ERROR_IF_EXC and lets us log it), but this raw CallObjectMethod still lets a Java exception pending on the thread. Could we use the same JniCall + LOG(WARNING) shape here? http://gerrit.cloudera.org:8080/#/c/24989/3/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/24989/3/tests/query_test/test_iceberg.py@1356 PS3, Line 1356: def test_metadata_table_base_table_changed(self, unique_database): nit: This test could be flaky. Although we can make it deterministic with a debug action if needed in the future. -- To view, visit http://gerrit.cloudera.org:8080/24989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0519035ecdca966bdc1a26147a157dc62bad2d8f Gerrit-Change-Number: 24989 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 05 Oct 2026 09:36:50 +0000 Gerrit-HasComments: Yes
